Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Speaker Diarization for Interview Analysis #59

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

AjinkyaASK
Copy link
Contributor

No description provided.

@AjinkyaASK AjinkyaASK changed the title Feature/speaker diarization Add Speaker Diarization for Interview Analysis Dec 11, 2024
Copy link

@Selectus2 Selectus2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhishek-Jain-1925 please check given suggestions and apply wherever used in the entire project.

app/src/app/api/analyse/get/route.ts Outdated Show resolved Hide resolved
app/src/app/api/feedback/route.ts Outdated Show resolved Hide resolved
app/src/app/api/feedback/route.ts Outdated Show resolved Hide resolved
app/src/app/api/signin/route.ts Outdated Show resolved Hide resolved

if (!user) return redirect("/signin");

if (!user) return redirect("/signin");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify above to improve readability and also move this logic to Higher Order component instead of calling separately for each page.


const form = useForm<AiCruitRequest>({
resolver: zodResolver(aiCruitRequestSchema),
defaultValues: {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always use constants for default values and the constants should be defined in separate file.

name="candidate_name"
render={({ field }) => (
<FormItem>
<FormLabel>Candidate Name</FormLabel>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

store form attributes and labels in constant and use that map it with FormField.

app/src/components/InterviewAnalysisItem.tsx Outdated Show resolved Hide resolved
Remove inappropriate redirection
Fix naming conventions
Code optimization
<p>Overview -</p>
<ReadMore
summary={
"Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove static response messages

@@ -18,6 +18,21 @@ export const signupUserSchema = z.object({

});

export const aiCruitRequestSchema = z.object({

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have all the constants in a single file

interviewerName: interviewAnalysis.interviewerName,
})
.from(interviewAnalysis)
.limit(10)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid using numbers without context. Use constants to improve readability

if (error instanceof z.ZodError) {
return new Response(error.message, { status: 422 });
}
return new Response("Failed to fetch error analysis", { status: 500 });

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Store all the error/success messages in one file and then use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants